Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

New Website: Remove Old Content [2/3] #15885

Merged
merged 26 commits into from
Sep 19, 2019

Conversation

ThomasDelteil
Copy link
Contributor

@ThomasDelteil ThomasDelteil commented Aug 14, 2019

This specific commit can be reviewed here in isolation here for better readability: ThomasDelteil#5

This removes the old website

New website visible here: https://mxnet-beta.staged.apache.org/

Merging this will disable website validation on PRs and any updates to the website until the follow-up PR is merged to add CI for the new docs and website: #15883

ThomasDelteil and others added 2 commits August 13, 2019 16:50
Co-authored-by: Thomas Delteil <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>
Co-authored-by: Thomas Delteil <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>
@zachgk
Copy link
Contributor

zachgk commented Sep 13, 2019

Can you rebase onto master to isolate the new commits from the commits that were part of New Website PR 1?

@ThomasDelteil
Copy link
Contributor Author

@zachgk way too many merge conflicts when trying to rebase sorry, let's try that way for now

@aaronmarkham aaronmarkham changed the title [WIP] New Website: Remove Old Content [2/3] New Website: Remove Old Content [2/3] Sep 18, 2019
Copy link
Contributor

@aaronmarkham aaronmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Ship it!

@aaronmarkham aaronmarkham merged commit f5d8fbf into apache:master Sep 19, 2019
larroy pushed a commit to larroy/mxnet that referenced this pull request Sep 28, 2019
* Adding new website files

Co-authored-by: Thomas Delteil <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>

* removing old content

Co-authored-by: Thomas Delteil <[email protected]>
Co-authored-by: Aaron Markham <[email protected]>

* add license header

* fixing links and url + css

* fixing tutorials

* exclude python_docs folder when building prod site

This allows things to coexist until a following PR deletes this file.

* license header fixes

* exclude static site from license header check

* exclude static site and sphinx theme

* exclude static_site and cpp_docs from sphinx

* add licenses and excludes

* fix headers

* restore file for legacy builds

* empty commit to trigger CI

* update submodule to correct one

* delete website check

* add placeholder website check

* add placeholder website check, for reals this time

* trigger CI

* trigger PR
@mikeobr
Copy link

mikeobr commented Oct 9, 2019

There's a tutorial I was looking for that seems to be removed in this PR, here it is on 1.4.0: https://github.com/apache/incubator-mxnet/blob/1.4.0/docs/tutorials/vision/cnn_visualization.md

Where did this get moved to?

@szha
Copy link
Member

szha commented Oct 10, 2019

@aaronmarkham @ThomasDelteil 👆

@ThomasDelteil
Copy link
Contributor Author

Yes there is a PR to add a few missing tutorials I'll double check this one is included, as soon as the CI is more stable we'll get it in.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants